feat(core): expose Question.ask via API/SDK#8404
Closed
eXamadeus wants to merge 16 commits intoanomalyco:devfrom
Closed
feat(core): expose Question.ask via API/SDK#8404eXamadeus wants to merge 16 commits intoanomalyco:devfrom
Question.ask via API/SDK#8404eXamadeus wants to merge 16 commits intoanomalyco:devfrom
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
1 task
eXamadeus
force-pushed
the
feat/question-ask
branch
from
a4cbb10 to
68a801e
Compare
eXamadeus
commented
Jan 14, 2026
| Bus.publish(Event.Asked, info) | ||
| }) | ||
|
|
||
| return (awaitAnswers ? answerPromise : id) as T extends true ? typeof answerPromise : typeof id |
Contributor
Author
There was a problem hiding this comment.
This conditional type makes it very safe to use:
Contributor
Author
|
/review EDIT: 😢 I was hoping I could summon a review bot to give me some early feedback, heh. |
…ng sent back as assistant message content (#11270) Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com>
opencode-agent
bot
force-pushed
the
dev
branch
from
00637c0 to
71e0ba2
Compare
thdxr
force-pushed
the
dev
branch
2 times, most recently
from
f1ae801 to
08fa7f7
Compare
Contributor
Author
|
Closing in favor of #12046 which is from a new fork I can maintain easier. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes: #8384
Important
The LOC changes are misleading, it's mostly tests and generated code.
Exposes a new
POST /question/askserver endpoint that allows clients and the SDK to programmatically ask questions to users without blocking. Key changes:Question.ask()function to support an optionaloptionsparameter with anawaitAnswerskey:awaitAnswers: true(default): blocks and returns the answers (existing behavior)awaitAnswers: false: returns the question request ID immediately without waiting for answers/question/askAPI endpoint that creates a question request and returns its ID, enabling async question flows from external clients/question/askendpoint performs session existence validation and returns 404 when the session doesn't existQuestion.AskInputschema fromQuestion.Requestto provide a clean input type for the new endpoint (without the server-generatedidfield)Question.ask()method and types (QuestionAskInput,QuestionAskResponses, etc.)How did you verify your code works?
Question.askrefactor intest/question/question.test.tstest/server/question.test.ts: